Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Depend on somacore 1.0.6 #1940

Merged
merged 1 commit into from
Dec 4, 2023
Merged

[python] Depend on somacore 1.0.6 #1940

merged 1 commit into from
Dec 4, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Dec 4, 2023

Issue and/or context: For issue #1930 and PR #1934

Changes:

Notes for Reviewer:

@johnkerl johnkerl requested a review from ebezzi December 4, 2023 17:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

Merging #1940 (f49bb77) into main (8616aa0) will increase coverage by 26.65%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1940       +/-   ##
===========================================
+ Coverage   63.11%   89.77%   +26.65%     
===========================================
  Files         106       34       -72     
  Lines       10056     3598     -6458     
===========================================
- Hits         6347     3230     -3117     
+ Misses       3709      368     -3341     
Flag Coverage Δ
python 89.77% <ø> (ø)
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.77% <ø> (ø)
libtiledbsoma ∅ <ø> (∅)

Copy link
Contributor

@thetorpedodog thetorpedodog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @ebezzi!

@johnkerl johnkerl merged commit 04ab23e into main Dec 4, 2023
9 checks passed
@johnkerl johnkerl deleted the kerl/use-somacore-106 branch December 4, 2023 18:06
github-actions bot pushed a commit that referenced this pull request Dec 4, 2023
johnkerl added a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants